Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove IUC conda channel from default configuration #10608

Merged
merged 1 commit into from
Nov 18, 2020

Conversation

bernt-matthias
Copy link
Contributor

I suggest to drop the IUC conda channel. My initial motivation an error caused by the emboss package in this channel:

ClobberError: This transaction has incompatible packages due to a shared path.
  packages: iuc::emboss-5.0.0-0, conda-forge::libpng-1.6.37-h21135ba_2
  path: 'share/man/man5/png.5'

But I guess its not needed anymore.

@galaxybot galaxybot added this to the 21.01 milestone Nov 2, 2020
@nsoranzo
Copy link
Member

nsoranzo commented Nov 2, 2020

Can you please run make config-rebuild and commit the changes it makes?

@nsoranzo nsoranzo requested a review from bgruening November 3, 2020 09:46
@bernt-matthias
Copy link
Contributor Author

Can you please run make config-rebuild and commit the changes it makes?

Done.

Wondering if building (mulled) containers needs to be adapted accordingly?

@bgruening
Copy link
Member

The reason we added this channel is to have a fallback for anything that is too ugly to get into bioconda. Do we still have this fear? If so we should fix/update the EMBOSS package instead of removing the channel.

@bernt-matthias
Copy link
Contributor Author

I understand .. seems reasonable. But with the current channel order its not a fallback, but the default -- isn't it?

Maybe a bit more background. I was trying to install rnaquast (https://github.com/bioconda/bioconda-recipes/blob/master/recipes/rnaquast/meta.yaml) and for some reason it used emboss 5.0.0. from the IUC channel instead of a newer one from bioconda. So I was thinking that the IUC package causes the problems.

So I see that removing the cannel seems not the best idea at the moment. Maybe a different channel priority would be an idea. channel-priority: disabled (i.e. --no-channel-priority) would be an option since then IUC packages are only considered in case of ties.

@bgruening
Copy link
Member

We could remove the EMBOSS package from the IUC channel, without changing anything?
I think our thinking to include iuc at the front was so that we can overwrite packages from other channels if really needed. But again we tried to be prepared for a case that never occured. So if you all want to drop it, I'm ok with it.

@bernt-matthias
Copy link
Contributor Author

We could remove the EMBOSS package from the IUC channel, without changing anything?

I think this would help for my problem. But to be 100% sure one would need to test he emboss tools with the bioconda package.

I think our thinking to include iuc at the front was so that we can overwrite packages from other channels if really needed. But again we tried to be prepared for a case that never occured. So if you all want to drop it, I'm ok with it.

Since I'm not sure about the other packages .. the safer change would be to change the channel priority... or?

channel_priority (ChannelPriority)
Accepts values of 'strict', 'flexible', and 'disabled'. The default
value is 'flexible'. With strict channel priority, packages in lower
priority channels are not considered if a package with the same name
appears in a higher priority channel. With flexible channel priority,
the solver may reach into lower priority channels to fulfill
dependencies, rather than raising an unsatisfiable error. With channel
priority disabled, package version takes precedence, and the
configured priority of channels is used only to break ties. ...

@mvdbeek
Copy link
Member

mvdbeek commented Nov 3, 2020

It's easy enough to add the channel back with a lower priority, should the need arise.

@mvdbeek mvdbeek changed the title drop IUC conda channel Remove IUC conda channel form default configuration Nov 3, 2020
@mvdbeek mvdbeek changed the title Remove IUC conda channel form default configuration Remove IUC conda channel from default configuration Nov 3, 2020
@mvdbeek mvdbeek merged commit 641b7e9 into galaxyproject:dev Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants