Drop history update_time triggers and replace with session listener / update query #10254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvdbeek
force-pushed
the
drop_triggers
branch
2 times, most recently
from
90496e9 to
2bb038e
Compare
mvdbeek
force-pushed
the
drop_triggers
branch
from
2bb038e to
6ea5dcf
Compare
nsoranzo
reviewed
Sep 21, 2020
mvdbeek
force-pushed
the
drop_triggers
branch
from
6ea5dcf to
2d48d8b
Compare
Closed
mvdbeek
force-pushed
the
drop_triggers
branch
from
2d48d8b to
863f601
Compare
I guess we also need to handle those places where we side-step the ORM (https://github.com/galaxyproject/galaxy/blob/0fd813c6d7958395a629e6753e4d20c916208615/lib/galaxy/model/__init__.py#L1200, https://github.com/galaxyproject/galaxy/blob/0fd813c6d7958395a629e6753e4d20c916208615/lib/galaxy/model/__init__.py#L1142)
mvdbeek
force-pushed
the
drop_triggers
branch
from
863f601 to
a19ef19
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That's an attempt to fix #10245 ... my hunch is that the trigger and the ORM's on_update function are colliding. I could be totally wrong though, and I also don't have a good way to test if this really fixes anything, but overall not using triggers might give us a better shot at figuring out on the application level where the deadlock occurs. maybe.
Let's see if this even passes tests.