Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abstraction for purging the dataset quota usage from a user. #10208

Merged
merged 1 commit into from
Sep 10, 2020

Conversation

jmchilton
Copy link
Member

Deduplicates the if and the arg call - but the amount of de-duplicated code would be increased in https://github.com/galaxyproject/galaxy/pull/4840/files where there is a second if based on hda.dataset.has_active_storage_media.

Deduplicates the if and the arg call - but the amount of de-duplicated code would be increased in https://github.com/galaxyproject/galaxy/pull/4840/files where there is a second if based on hda.dataset.has_active_storage_media.
@jmchilton jmchilton added kind/refactoring cleanup or refactoring of existing code, no functional changes area/objectstore labels Sep 10, 2020
@galaxybot galaxybot added this to the 21.01 milestone Sep 10, 2020
@dannon dannon modified the milestones: 21.01, 20.09 Sep 10, 2020
@dannon
Copy link
Member

dannon commented Sep 10, 2020

Unrelated test failures.

@dannon dannon merged commit 1743e7f into galaxyproject:dev Sep 10, 2020
@nsoranzo nsoranzo deleted the purge_usage_from_quota branch September 10, 2020 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/objectstore kind/refactoring cleanup or refactoring of existing code, no functional changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants