Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: David López <[email protected]>
  • Loading branch information
jmchilton and davelopez authored May 15, 2023
1 parent 31a295c commit 671e819
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ interface Props {
admin: boolean; // was the configuration specified by an admin
}
const props = defineProps<Props>();
const markdownHtml = computed(() => markup(props.markdown || "", props.admin));
const markdownHtml = computed(() => markup(props.markdown ?? "", props.admin));
</script>
<template>
<!-- Disable v-html warning because we allow markdown generated HTML
Expand Down
2 changes: 1 addition & 1 deletion client/src/components/ObjectStore/ObjectStoreBadge.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ describe("ObjectStoreBadge", () => {
expect(popoverText).toContain("less secure by the Galaxy administrator");
});

it("should gracefully unspecified badge messages", async () => {
it("should gracefully handle unspecified badge messages", async () => {
mountBadge({ type: "more_secure", message: null });
const selector = ROOT_COMPONENT.object_store_details.badge_of_type({ type: "more_secure" }).selector;
const iconEl = wrapper.find(selector);
Expand Down

0 comments on commit 671e819

Please sign in to comment.