Skip to content

Commit

Permalink
Remove unnecessary user setup from tests
Browse files Browse the repository at this point in the history
  • Loading branch information
davelopez committed Mar 22, 2021
1 parent d60c8d8 commit 38f64bd
Showing 1 changed file with 2 additions and 7 deletions.
9 changes: 2 additions & 7 deletions lib/galaxy_test/api/test_folder_contents.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,6 @@
)
from ._framework import ApiTestCase

OWNNER_USER = '[email protected]'
ANOTHER_USER = '[email protected]'


class FolderContentsApiTestCase(ApiTestCase):

Expand Down Expand Up @@ -141,8 +138,6 @@ def test_index_search_text(self):
assert len(contents) == len(matching_names)

def test_index_permissions_include_deleted(self):
self._setup_user(ANOTHER_USER)
self._setup_user(OWNNER_USER)

folder_name = "Test Folder Contents Index permissions include deteleted"
folder_id = self._create_folder_in_library(folder_name)
Expand Down Expand Up @@ -195,12 +190,12 @@ def test_index_permissions_include_deleted(self):
assert len(contents) == num_total_contents

# Users with access but no modify permission can't see deleted
with self._different_user(ANOTHER_USER):
with self._different_user():
different_user_role_id = self.dataset_populator.user_private_role_id()

self._allow_library_access_to_user_role(different_user_role_id)

with self._different_user(ANOTHER_USER):
with self._different_user():
response = self._get(f"folders/{folder_id}/contents?include_deleted={include_deleted}")
self._assert_status_code_is(response, 200)
contents = response.json()["folder_contents"]
Expand Down

0 comments on commit 38f64bd

Please sign in to comment.