Skip to content

Commit

Permalink
minor changes and cleanup
Browse files Browse the repository at this point in the history
  • Loading branch information
martenson committed May 4, 2023
1 parent a66560e commit 17c2e26
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 9 deletions.
2 changes: 1 addition & 1 deletion client/src/components/Indices/filtersMixin.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ export default {
},
computed: {
isFiltered() {
return !!this.filter;
return Boolean(this.filter);
},
effectiveFilter() {
let filter = this.filter;
Expand Down
11 changes: 3 additions & 8 deletions client/src/components/admin/JobsList.vue
Original file line number Diff line number Diff line change
Expand Up @@ -36,11 +36,7 @@
</b-form-group>
</b-form>
<b-form-group description="Use strings or regular expressions to search jobs.">
<IndexFilter
id="job-search"
v-model="filter"
:placeholder="titleSearchJobs"
:help-html="helpHtml" />
<IndexFilter v-bind="filterAttrs" id="job-search" v-model="filter" />
</b-form-group>
</b-col>
</b-row>
Expand Down Expand Up @@ -109,7 +105,6 @@ import { commonJobFields } from "./JobFields";
import { errorMessageAsString } from "utils/simple-error";
import { jobsProvider } from "components/providers/JobProvider";
import Heading from "components/Common/Heading";
import IndexFilter from "components/Indices/IndexFilter";
import filtersMixin from "components/Indices/filtersMixin";
function cancelJob(jobId, message) {
Expand Down Expand Up @@ -144,7 +139,7 @@ returned. So <code>tool:'cat1'</code> would show only jobs from the <code>cat1</
`;
export default {
components: { JobLock, JobsTable, Heading, IndexFilter },
components: { JobLock, JobsTable, Heading },
mixins: [filtersMixin],
data() {
return {
Expand All @@ -169,7 +164,7 @@ export default {
busy: true,
cutoffMin: 5,
showAllRunning: false,
titleSearchJobs: `search jobs`,
titleSearch: `search jobs`,
helpHtml: helpHtml,
};
},
Expand Down

0 comments on commit 17c2e26

Please sign in to comment.