Add limit, offset and include_deleted to show_folder
#494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bernt-matthias
force-pushed
the
folder-update
branch
3 times, most recently
from
4df08d9 to
99cd859
Compare
bernt-matthias
force-pushed
the
folder-update
branch
3 times, most recently
from
36073c5 to
790a7f7
Compare
bernt-matthias
force-pushed
the
folder-update
branch
from
790a7f7 to
5b889cf
Compare
bernt-matthias
force-pushed
the
folder-update
branch
from
b611bde to
7fc18e4
Compare
bernt-matthias
changed the title
limit, offset and include_deleted to show_folder
bernt-matthias
force-pushed
the
folder-update
branch
from
7fc18e4 to
c1700ad
Compare
bernt-matthias
force-pushed
the
folder-update
branch
from
c1700ad to
c49b94a
Compare
nsoranzo
reviewed
Jan 30, 2025
nsoranzo
reviewed
Jan 30, 2025
nsoranzo
reviewed
Jan 30, 2025
Co-authored-by: Nicola Soranzo <[email protected]>
Co-authored-by: Nicola Soranzo <[email protected]>
nsoranzo
reviewed
Jan 30, 2025
Co-authored-by: Nicola Soranzo <[email protected]>
nsoranzo
reviewed
Jan 30, 2025
Co-authored-by: Nicola Soranzo <[email protected]>
|
Maybe like this: 30c4c91 simplifies the code I'm working on quite a bit: |
nsoranzo
reviewed
Jan 31, 2025
nsoranzo
reviewed
Jan 31, 2025
nsoranzo
reviewed
Jan 31, 2025
All BioBlend low-level wrapper methods for containers (histories, libraries, folders) currently work this way, maybe it'd be useful to improve the method annotation with overloads, like https://github.com/galaxyproject/bioblend/blob/main/bioblend/galaxy/histories/__init__.py#L307-L335
Usually this (slightly) higher-level manipulation have been implemented in BioBlend.objects , but this looks fine to me. |
Co-authored-by: Nicola Soranzo <[email protected]>
bernt-matthias
force-pushed
the
folder-update
branch
from
dfef8a7 to
4a46da3
Compare
Co-authored-by: Nicola Soranzo <[email protected]>
bernt-matthias
force-pushed
the
folder-update
branch
from
171ed43 to
687d281
Compare
nsoranzo
reviewed
Feb 4, 2025
Co-authored-by: Nicola Soranzo <[email protected]>
nsoranzo
reviewed
Feb 4, 2025
Co-authored-by: Nicola Soranzo <[email protected]>
nsoranzo
reviewed
Feb 4, 2025
nsoranzo
reviewed
Feb 4, 2025
bernt-matthias
force-pushed
the
folder-update
branch
from
4385944 to
b442c17
Compare
Co-authored-by: Nicola Soranzo <[email protected]>
nsoranzo
reviewed
Feb 4, 2025
|
Could we create a release together with #492 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.