feat: liquidity mining for xyk pallet #798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…used uniuqes compatible traits + fixed tests
…farm that distributes insufficient asset
|
New crates:
Crate versions that have been updated:
Runtime version has been increased. |
jak-pan
reviewed
Apr 9, 2024
| vec, | ||
| }; | ||
|
|
||
| const INSSUFFICIENT_ASSET_ED_MULTIPLIER: u8 = 2; |
There was a problem hiding this comment.
I don't think we need this multiplier
jak-pan
reviewed
Apr 9, 2024
| let ed = | ||
| T::AssetRegistry::existential_deposit(reward_currency).ok_or(Error::<T>::AssetNotRegistered)?; | ||
|
|
||
| let pot = T::LiquidityMiningHandler::pot_account().ok_or(Error::<T>::FailToGetPotId)?; |
There was a problem hiding this comment.
As I understand we need to seed the pot with ED on farm creation. We have two pots though, the first one is seeded on transfer by the farm creator. We could put some comment about this fact.
jak-pan
reviewed
Apr 9, 2024
| /// Pallet id. | ||
| type PalletId: Get<PalletId>; | ||
|
|
||
| /// NFT collection id for liq. mining deposit nfts. Has to be within the range of reserved NFT class IDs. |
There was a problem hiding this comment.
Suggested change
| /// NFT collection id for liq. mining deposit nfts. Has to be within the range of reserved NFT class IDs. |
jak-pan
reviewed
Apr 9, 2024
Yes, committed weights are from new benchmarks with insufficient assets |
jak-pan
approved these changes
Apr 9, 2024
mrq1911
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds liquidity mining support for xyk pools.