fix: set route validation for lower liquidity pools #789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dmoka
commented
Mar 15, 2024
•
dmoka
commented
- Return the specific error when route validation fails
- Fix bug of inconsistent intermediate assets
- Fix set route validation to use the lowest asset liqudity as reference
- Add test for the new validation logic where inverse route is broken
- Add set route without validation to be called by TE
- Adjust documentation
- rebenchmark as there is a new extrinsic, and add this benchmark method the the extrinsic
- Test failing PROD cases if they are really solved
…nt in the route trades
|
Crate versions that have been updated:
Runtime version has been increased. |
mrq1911
changed the title
…oute for safety reasons.
mrq1911
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.