Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: spent and received amount checks in router #781

Merged
merged 4 commits into from
Mar 11, 2024
Merged

feat: spent and received amount checks in router #781

merged 4 commits into from
Mar 11, 2024

Conversation

dmoka
Copy link
Contributor

@dmoka dmoka commented Mar 5, 2024 •
edited
Loading

We add back two checks to router:

  • if the user at least spent the amount they should have
  • if the user received at most the amount the should have

Router pallet is also rebenchmarked

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 5, 2024

Crate versions that have been updated:

  • runtime-integration-tests: v1.19.6 -> v1.19.7
  • pallet-route-executor: v2.0.2 -> v2.1.0
  • hydradx-runtime: v221.0.0 -> v222.0.0

Runtime version has been increased.

@mrq1911 mrq1911 changed the title fix: add spent and received amount checks to router feat: spent and received amount checks to router Mar 11, 2024
@mrq1911 mrq1911 changed the title feat: spent and received amount checks to router feat: spent and received amount checks in router Mar 11, 2024
@mrq1911 mrq1911 merged commit 9d70968 into master Mar 11, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrq1911 mrq1911 mrq1911 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dmoka @mrq1911