fix: adjust router for insufficient asset #765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # pallets/route-executor/src/lib.rs
|
Crate versions that have been updated:
Runtime version has been increased. |
…trade so precise balance check is not possible
|
WARNING: dont merge it yet, we will rework to get the ED from asset registry |
# Conflicts: # Cargo.lock # integration-tests/Cargo.toml # integration-tests/src/router.rs
jak-pan
reviewed
Feb 21, 2024
dmoka
changed the title
…we discarded the it
dmoka
changed the title
# Conflicts: # Cargo.lock # integration-tests/Cargo.toml # runtime/adapters/Cargo.toml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we introduced insufficient assets, the balance check won't work properly as we can have special case with selling fee payment asset for shitcoin, so we decided to remove it.
Furthermore we wanna disable route setting for insufficient asset
TODO: