feat: EVM account binding #761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New crates:
Crate versions that have been updated:
Runtime version has been increased. |
| } | ||
|
|
||
| /// Return the Substrate address bound to the EVM account. If not bound, returns `None`. | ||
| pub fn bound_account_id(evm_address: EvmAddress) -> Option<T::AccountId> { |
There was a problem hiding this comment.
this does not bound the account. i would suggest not to use a verb. Something like
bounded_account_id would be more clear
There was a problem hiding this comment.
It's not bind, so I believe it's ok as it is.
There was a problem hiding this comment.
bound is also a verb;-)
anyway, i find the wording bit too dificult to understand. there are functions named - get bound account, get truncated account, get account id, evm addres ...
without looking at the params - it kinda hard to understand what each one does.
Co-authored-by: Martin Hloska <[email protected]>
Co-authored-by: Martin Hloska <[email protected]>
mrq1911
requested changes
Feb 18, 2024
mrq1911
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.