feat: xcm exchange asset #714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Crate versions that have been updated:
Runtime version has been increased. |
mrq1911
reviewed
Dec 19, 2023
| @@ -210,7 +216,7 @@ impl pallet_xcm::Config for Runtime { | |||
| type SendXcmOrigin = EnsureXcmOrigin<RuntimeOrigin, LocalOriginToLocation>; | |||
| type XcmRouter = XcmRouter; | |||
| type ExecuteXcmOrigin = EnsureXcmOrigin<RuntimeOrigin, LocalOriginToLocation>; | |||
| type XcmExecuteFilter = Nothing; | |||
| type XcmExecuteFilter = AllowTransferAndSwap<MaxXcmDepth, MaxNumberOfInstructions, RuntimeCall>; | |||
There was a problem hiding this comment.
why is this change necessary? i dont think we are planning to execute xcm messages locally and xcm::execute extrinsic is call filtered anyway currently
There was a problem hiding this comment.
We want it in combination with changing the call filter to allow UIs to interact with the chain through pallet_xcm::execute. This is part of the XCM exchange asset stuff.
Concretely you could imagine our UI swapping tokens on Hydra and then sending them to the destination in one extrinsic/with one XCM.
mrq1911
requested changes
Dec 19, 2023
mrq1911
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We enable AssetExchange xcm message instruction in hydra.
It also means that we needed to change the
XcmFilterof pallet_xcm fromNothingtoAllowTransferAndSwap, which is a more permissive in terms of allowed xcm instructions.Related Issue
Motivation and Context
How Has This Been Tested?
Checklist: