refactor: registry traits consolidation #701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Crate versions that have not been updated:
Crate versions that have been updated:
Runtime version has not been increased. |
| Token, | ||
| PoolShare(AssetId, AssetId), // Use XYX instead |
There was a problem hiding this comment.
this would require migration in basislisk ?
pallets/bonds/src/lib.rs
Outdated
| @@ -128,6 +131,9 @@ pub mod pallet { | |||
| #[pallet::constant] | |||
| type FeeReceiver: Get<Self::AccountId>; | |||
|
|
|||
| /// Asset location type | |||
| type AssetLocation: Parameter + Member + Default + MaxEncodedLen; | |||
There was a problem hiding this comment.
Same thing here as in xyk
apopiak
approved these changes
Nov 14, 2023
pallets/asset-registry/src/lib.rs
Outdated
Comment on lines
724
to
727
| let bounded_name = match Self::try_into_bounded(Some(name.to_vec()))? { | ||
| Some(n) => n, | ||
| None => return Err(Error::<T>::InvalidAssetname.into()), | ||
| }; |
There was a problem hiding this comment.
Suggested change
| let bounded_name = match Self::try_into_bounded(Some(name.to_vec()))? { | |
| Some(n) => n, | |
| None => return Err(Error::<T>::InvalidAssetname.into()), | |
| }; | |
| let bounded_name = Self::try_into_bounded(Some(name.to_vec())).map_err(|_| Error::<T>::InvalidAssetname)?; |
Shouldn't need the match, no?
There was a problem hiding this comment.
But this would suppress error returned from try_into_bounded().
InvalidAssetname is something that should never happen. try_into_bounded returns None only if None was provided as param.
| @@ -36,6 +36,7 @@ use sp_runtime::{ | |||
| use std::cell::RefCell; | |||
| use std::collections::HashMap; | |||
| use std::marker::PhantomData; | |||
| //use frame_system::GenesisConfig; | |||
pallets/lbp/src/types.rs
Outdated
| @@ -0,0 +1,67 @@ | |||
| // This file is part of Basilisk-node. | |||
There was a problem hiding this comment.
Suggested change
| // This file is part of Basilisk-node. | |
| // This file is part of HydraDX-node. |
pallets/lbp/src/types.rs
Outdated
| use serde::{Deserialize, Serialize}; | ||
|
|
||
| /// Asset Pair representation for AMM trades | ||
| /// ( asset_a, asset_b ) combination where asset_a is meant to be exchanged for asset_b |
There was a problem hiding this comment.
Suggested change
| /// ( asset_a, asset_b ) combination where asset_a is meant to be exchanged for asset_b | |
| /// `( asset_in, asset_out )` combination where `asset_in` is meant to be exchanged for `asset_out` |
pallets/lbp/src/types.rs
Outdated
Comment on lines
32
to
33
| /// asset_in represents asset coming into the pool | ||
| /// asset_out represents asset coming out of the pool |
There was a problem hiding this comment.
Suggested change
| /// asset_in represents asset coming into the pool | |
| /// asset_out represents asset coming out of the pool | |
| /// `asset_in` represents asset coming into the pool | |
| /// `asset_out` represents asset coming out of the pool |
enthusiastmartin
approved these changes
Nov 16, 2023
martinfridrich
merged commit f88cc0b
into
feat/permissionless-asset-registry
3 of 4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR consolidates registry traits and refactors all the pallets/code to use new traits and removes old registry traits.