Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: permissionless asset-registry #655

Merged
merged 106 commits into from
Feb 20, 2024
Merged

feat: permissionless asset-registry #655

merged 106 commits into from
Feb 20, 2024

Conversation

martinfridrich
Copy link
Contributor

@martinfridrich martinfridrich commented Aug 15, 2023 •
edited
Loading

Permisionless asset-registry

Changes in asset-registry

  • asset-registry refactor, storage reorganization and make properties optional
  • added extrinsic to permissionlessly register that has only asset location
  • created new traits for asset-registry. Refactor of other pallets to use new traits will done in separate PR
  • implemented ED for insufficient assets

TODO:

@github-actions
Copy link

github-actions bot commented Aug 15, 2023 •
edited
Loading

Crate versions that have been updated:

  • runtime-integration-tests: v1.17.5 -> v1.18.0
  • hydradx: v12.0.0 -> v12.1.0
  • pallet-asset-registry: v2.3.3 -> v3.0.0
  • pallet-bonds: v2.0.1 -> v2.1.0
  • pallet-circuit-breaker: v1.1.19 -> v1.1.20
  • pallet-dca: v1.3.3 -> v1.3.4
  • pallet-lbp: v4.7.3 -> v4.7.4
  • pallet-liquidity-mining: v4.2.5 -> v4.3.0
  • pallet-omnipool: v4.1.2 -> v4.1.3
  • pallet-omnipool-liquidity-mining: v2.0.13 -> v2.1.0
  • pallet-otc: v1.0.3 -> v1.1.0
  • pallet-route-executor: v2.0.0 -> v2.0.1
  • pallet-stableswap: v3.4.3 -> v3.4.4
  • pallet-transaction-multi-payment: v9.2.1 -> v9.3.0
  • pallet-xcm-rate-limiter: v0.1.4 -> v0.1.5
  • pallet-xyk: v6.3.4 -> v6.4.0
  • hydradx-adapters: v1.1.0 -> v1.1.1
  • hydradx-runtime: v209.0.0 -> v210.0.0
  • hydradx-traits: v2.8.4 -> v3.0.0

Runtime version has been increased.

martinfridrich and others added 25 commits August 23, 2023 12:17
@martinfridrich
asset-registry: WIP make params optional + tests
4639f8b
@martinfridrich
asset-registry: remove debug println
43880b8
@martinfridrich
asset-registry: WIP pallet refactor
c2f5051
@martinfridrich
asset-registry: added tests for update and minor fixes
f557c86
@martinfridrich
asset-registry: added register() tests
9aec800
@martinfridrich
asset-registry: fix runtime and chain spec changes
5763a85
@martinfridrich
asset-registry: fixed tests in all the pallets
4931534
@martinfridrich
asset-registry: fixed benchmarks
5c71166
@martinfridrich
asset-registry: added asset_id to CreateRegistry trait
d786741
@martinfridrich
asset-registry: make clippy happy
c77fc9f
@jak-pan
review
a66a3d0
@martinfridrich
asset-registry: revert changes old registry trait and pallets using i…
2d80b18 
…t + minor refactor and start of new traits for asset registry
@martinfridrich
asset-registry: fixed xcm_rate_limit update
634a330
@martinfridrich
Merge branch 'feat/permissionless-asset-registry' of github.com:galac…
82b0845 
…ticcouncil/HydraDX-node into feat/permissionless-asset-registry
@martinfridrich
asset-registry: fix review comments
16d587f
@martinfridrich
Merge branch 'master' into feat/permissionless-asset-registry
4c9c248
@martinfridrich
asset-registry: integration tests
7c93b90
@martinfridrich
asset-registry: implemented extrinsic to create external assets
bce9bcb
@martinfridrich
asset-registry: added benchmarks for register_external()
ed92f48
@martinfridrich
asset-registry: WIP sufficiency check
797620e
@martinfridrich
asset-registry: wip suffiency check, remove lock when all tokens shou…
49f793a 
…ld be unlocked
@martinfridrich
asset-registry: added tests for sufficiency check
faad304
@martinfridrich
asset-registry: added whitelist to suffiency check + tests
6cb9082
@martinfridrich
asset-registry: make clippy happy
985c401
@martinfridrich
Merge branch 'master' into feat/permissionless-asset-registry
cb9d56b
enthusiastmartin
enthusiastmartin reviewed Jan 25, 2024
View reviewed changes
Copy link
Contributor

@enthusiastmartin enthusiastmartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update readme too.

pallets/asset-registry/src/lib.rs Outdated Show resolved Hide resolved
pallets/asset-registry/src/lib.rs Outdated Show resolved Hide resolved
pallets/asset-registry/src/lib.rs Outdated Show resolved Hide resolved
pallets/asset-registry/src/lib.rs Outdated Show resolved Hide resolved
pallets/asset-registry/src/lib.rs Show resolved Hide resolved
pallets/asset-registry/src/lib.rs Outdated Show resolved Hide resolved
jak-pan
jak-pan reviewed Feb 20, 2024
View reviewed changes
Copy link
Contributor

@jak-pan jak-pan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do we miss still? Looks good.

@martinfridrich
Copy link
Contributor Author

What do we miss still? Looks good.

I'm working on removing storage fess for external asset registration

@martinfridrich martinfridrich merged commit c609e97 into master Feb 20, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jak-pan jak-pan jak-pan approved these changes

@enthusiastmartin enthusiastmartin enthusiastmartin approved these changes

@apopiak apopiak apopiak approved these changes

@mrq1911 mrq1911 Awaiting requested review from mrq1911

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@martinfridrich @jak-pan @apopiak @enthusiastmartin