This repository has been archived by the owner on Oct 19, 2024. It is now read-only.
fix: make chain_id mandatory #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gakonst
force-pushed
the
fix/mandatory-chainid
branch
2 times, most recently
from
470dcd3 to
ed15abc
Compare
gakonst
force-pushed
the
fix/mandatory-chainid
branch
from
92cb8a6 to
738ac6d
Compare
* chore(deps): bump elliptic-curve from 0.10.4 to 0.10.5 Bumps [elliptic-curve](https://github.com/RustCrypto/traits) from 0.10.4 to 0.10.5. - [Release notes](https://github.com/RustCrypto/traits/releases) - [Commits](RustCrypto/traits@elliptic-curve-v0.10.4...elliptic-curve-v0.10.5) --- updated-dependencies: - dependency-name: elliptic-curve dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * chore: bump deps Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
gakonst
force-pushed
the
fix/mandatory-chainid
branch
from
738ac6d to
d9322de
Compare
gakonst
force-pushed
the
fix/mandatory-chainid
branch
from
79dd935 to
5252712
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since latest versions, geth has been rejecting non-eip155 transactions. as a result, we remove the
Option<u64>and replace it with justu64. This is a breaking changeThe method
address()was removed from theWallettype, since it's present in theSigner. If your code starts erroring out aboutaddress()not being available, importethers::signers::Signer.