Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a type parser and two new rules for types in JSdoc comments #67

Merged
merged 6 commits into from
Apr 6, 2018

Conversation

bary12
Copy link
Contributor

@bary12 bary12 commented Mar 23, 2018

Solves

Summary of changes:

  • Added Kuniwak/jsdoctypeparser as a runtime dependency, for parsing types inside JSdoc tags.
  • check-types now checks for inner types such as Array<String>. This is a Breaking change.
  • Added rule valid-types that checks there are no syntax errors when parsing the type. example of error: @param {Array<string} foo
  • Added rule no-undefined-types that checks all the types are defined in the scope, and marks types in JSdoc comments as used, so imports for types will not be marked as unused by no-unused-vars

This is a breaking change

@gajus gajus merged commit 323a133 into gajus:master Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants