Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure no-undefined-types catches modular scope for Node/commonjs env's #222

Merged
merged 4 commits into from
May 16, 2019
Merged

Ensure no-undefined-types catches modular scope for Node/commonjs env's #222

merged 4 commits into from
May 16, 2019

Conversation

brettz9
Copy link
Collaborator

@brettz9 brettz9 commented May 14, 2019 •
edited
Loading

  • Consider Node.js/Commonjs as module (including variables in module scope as well as global)
  • (Ensure all child scopes included if there can be more than 1)
  • Testing: Add one test with node false and another with node true

Fixes #109.

This was referenced May 14, 2019
Closed
Closed
@brettz9 brettz9 force-pushed the no-undefined-types-node branch 4 times, most recently from aedcd0b to 296712a Compare May 15, 2019 14:07
@brettz9 brettz9 force-pushed the no-undefined-types-node branch from 296712a to 7307d35 Compare May 15, 2019 23:48
@brettz9 brettz9 merged commit d91cc9c into gajus:master May 16, 2019
@brettz9 brettz9 deleted the no-undefined-types-node branch May 16, 2019 08:11
@gajus
Copy link
Owner

gajus commented May 21, 2019

🎉 This PR is included in version 6.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@gajus gajus added the released label May 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rule no-undefined-types does not work
2 participants
@brettz9 @gajus