fix(no-undefined-types): avoid supress tag type checking in closure; …

…fixes #815
gajus · Dec 17, 2021 · fac3f20 · fac3f20
1 parent 03f4ce7
commit fac3f20
Show file tree

Hide file tree

Showing 3 changed files with 50 additions and 1 deletion.
diff --git a/README.md b/README.md
@@ -9404,6 +9404,14 @@ function foo (bar) {
 };
 // Settings: {"jsdoc":{"mode":"closure"}}
 // Message: The type 'TEMPLATE_TYPE' is undefined.
+
+/**
+ * @suppress {visibility}
+ */
+function foo () {
+}
+// Settings: {"jsdoc":{"mode":"jsdoc"}}
+// Message: The type 'visibility' is undefined.
 ````
 
 The following patterns are not considered problems:
@@ -9757,6 +9765,13 @@ class Test {
 function quux(foo) {
 
 }
+
+/**
+ * @suppress {visibility}
+ */
+function foo () {
+}
+// Settings: {"jsdoc":{"mode":"closure"}}
 ````
 
 

diff --git a/src/rules/noUndefinedTypes.js b/src/rules/noUndefinedTypes.js
@@ -140,7 +140,7 @@ export default iterateJsdoc(({
     .concat(settings.mode === 'jsdoc' ? [] : closureGenericTypes));
 
   const jsdocTagsWithPossibleType = utils.filterTags(({tag}) => {
-    return utils.tagMightHaveTypePosition(tag);
+    return utils.tagMightHaveTypePosition(tag) && (tag !== 'suppress' || settings.mode !== 'closure');
   });
 
   for (const tag of jsdocTagsWithPossibleType) {

diff --git a/test/rules/assertions/noUndefinedTypes.js b/test/rules/assertions/noUndefinedTypes.js
@@ -426,6 +426,26 @@ export default {
         },
       },
     },
+    {
+      code: `
+      /**
+       * @suppress {visibility}
+       */
+      function foo () {
+      }
+      `,
+      errors: [
+        {
+          line: 3,
+          message: 'The type \'visibility\' is undefined.',
+        },
+      ],
+      settings: {
+        jsdoc: {
+          mode: 'jsdoc',
+        },
+      },
+    },
   ],
   valid: [
     {
@@ -1070,5 +1090,19 @@ export default {
       `,
       ignoreReadme: true,
     },
+    {
+      code: `
+      /**
+       * @suppress {visibility}
+       */
+      function foo () {
+      }
+      `,
+      settings: {
+        jsdoc: {
+          mode: 'closure',
+        },
+      },
+    },
   ],
 };