Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimal Hard Thresholding to determine optimal encoding dimension #69

Merged
merged 12 commits into from
Jul 31, 2024
Merged

Optimal Hard Thresholding to determine optimal encoding dimension #69

merged 12 commits into from
Jul 31, 2024

Conversation

andrearaithel
Copy link
Collaborator

@andrearaithel andrearaithel commented Jul 31, 2024 •
edited by AtaJadidAhari
Loading

Estimation of the optimal encoding dimension q based on the sample size in the estimateBestQ function is replaced by the OHT procedure. It provides a faster alternative to the findEncodingDim function.

  • move estimateBestQ from helperFunctions.R to controlForConfounders.R
  • replace estimation formula by deterministic OHT procedure
  • add pracma and RMTstat package to Imports
  • add denoiseR package to Suggests
  • add unit tests
  • add OHT reference to bibliography
  • update vignette
  • enable processing of datasets with an aspect ratio larger than 1
  • use GHA checkoutv4 & R v4.4 for mac and windows

@andrearaithel andrearaithel added the enhancement New feature or request label Jul 31, 2024
@AtaJadidAhari AtaJadidAhari merged commit 52581f5 into gagneurlab:OHT_clean Jul 31, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AtaJadidAhari AtaJadidAhari Awaiting requested review from AtaJadidAhari

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrearaithel @AtaJadidAhari