Robust plotting of profiles and their data from ZIPFIT and OMFIT_PROFS MDSplus trees #320
Conversation
…rict normal installation to appropriate versions
| - name: Install OMAS (Py 3.7) | ||
| if: ${{matrix.python-version == '3.7'}} | ||
| - name: Install OMAS (Py 3.7, 3.8, 3.9) | ||
| if: ${{matrix.python-version == '3.7' || matrix.python-version == '3.8' || matrix.python-version == '3.9'}} |
There was a problem hiding this comment.
Why do 3.8 and 3.9 now also need to be built w/o build isolation?
There was a problem hiding this comment.
I don't know exactly. I was getting an error about a compiler not being found (you can check the logs for the previous commits), and hoped that this fix would resolve the problem, and it did. I am not clear about what using this option does or what the implications are. If you have other suggestions, I am open to them. I would like to merge this very soon, as I have a live demo at the Supercomputing conference on Nov 18 that depends on these fixes. Of course I could work off of a branch, but that is not as preferable as getting this pull request merged.
There was a problem hiding this comment.
It looks like it's again a build problem, with pygacode. But I don't have access to that package, so these are hard to debug.
The downside is that users will also see this problem when they install omas
But this is present already on main: https://github.com/gafusion/omas/actions/runs/11557213043 so it should probably not block your PR. This seems like a reasonable patch in the meantime. But I'd suggest filing an issue to have the pygacode build fixed.
The removal of whitespace can be ignored with adding
?w=1to the files tab.The bugs were discovered while trying to plot profiles for the SC24 Demo (of CAKE and IRI).