Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the IMAS version to 3.41.0 #309

Merged
merged 7 commits into from
Jun 24, 2024
Merged

Update the IMAS version to 3.41.0 #309

merged 7 commits into from
Jun 24, 2024

Conversation

torrinba
Copy link
Collaborator

This seems like a relatively small change in the parts of the schema we use most. All tests pass right out of the box.

This seems like a relatively small change in the most used parts of
the schema at least. All tests pass right out of the box.
@torrinba torrinba added the IMAS label Jun 11, 2024
@torrinba torrinba requested review from orso82 and AreWeDreaming June 11, 2024 20:48
@torrinba torrinba self-assigned this Jun 11, 2024
@orso82
Copy link
Member

orso82 commented Jun 11, 2024

I assume you mean tests on your system pass? all tests in the CI seem to fail...

@torrinba
Copy link
Collaborator Author

I don't see any clear reason the CI failed (I can't find a meaningful error message)

@AreWeDreaming
Copy link
Collaborator

@orso82 Did Richard set up the CI for this or was it someone else?

@smithsp
Copy link
Member

smithsp commented Jun 17, 2024

I pushed a change here to try to get regressions to pass.

torrinba and others added 4 commits June 17, 2024 15:11
This might impact older numpy versions, so there could be better
ways to preserve backwards compatibility
This build is can no longer supported because of known issues with the pint module
hgrecco/pint#1974 (comment)
This build should avoid numpy 2.0 for now
@torrinba torrinba merged commit 27eca6d into master Jun 24, 2024
6 checks passed
@hassec
Copy link
Contributor

hassec commented Jun 24, 2024

With this merged, any chance we could get a new release on pypi that includes this?
And someonew should probably update the website to show the latest IMAS schema

@torrinba
Copy link
Collaborator Author

With this merged, any chance we could get a new release on pypi that includes this? And someonew should probably update the website to show the latest IMAS schema

Thanks for the reminder. I just updated the website.

I don't think I have permission to publish the new version to pypi, so we'll need @orso82 or @smithsp to do that

@smithsp
Copy link
Member

smithsp commented Jun 26, 2024

That was an adventure, but I have now uploaded a new pypi version.

@smithsp smithsp deleted the imas_3.41.0 branch June 26, 2024 22:20
@AreWeDreaming
Copy link
Collaborator

Now do condaforge =D

@smithsp
Copy link
Member

smithsp commented Jun 26, 2024

Conda-forge auto-updates

@hassec
Copy link
Contributor

hassec commented Jun 26, 2024

Thanks @smithsp 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants