Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes for MAST maching mappings. #308

Merged
merged 3 commits into from
Jun 5, 2024
Merged

fixes for MAST maching mappings. #308

merged 3 commits into from
Jun 5, 2024

Conversation

jmcclena
Copy link
Collaborator

@jmcclena jmcclena commented Jun 5, 2024

fixes for MAST maching mappings
Add MAST thomson scatter machine mapping

Add MAST thomson scatter machine mapping
@jmcclena jmcclena requested a review from torrinba June 5, 2024 19:45
Copy link
Collaborator

@torrinba torrinba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me. I don't have access to test with MAST data, but trust @jmcclena has already confirmed this

Unfortunately they break the regression tests unless pyuda is in the environment. Is that publicly available on any of our systems?

@torrinba torrinba self-requested a review June 5, 2024 19:49
@jmcclena
Copy link
Collaborator Author

jmcclena commented Jun 5, 2024

@torrinba The only two systems I know that it's installed on are portal and freia. Would it make sense to wrap the import of mast machine mappings in a try-except to quickly get the regression to pass?

omas/omas_machine.py Outdated Show resolved Hide resolved
@torrinba torrinba merged commit 61545ab into master Jun 5, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants