refactor(test) remove workaround for old omfit_classes version #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Interesting, it installed |
|
@hassec It looks like the new master wasn't created yet. I am guessing some (OMFIT) tests failed, but will take a look. (The new package has the previous master, just much newer one than the last package posted to pypi) |
|
(I am basically saying the fixed code isn't in the pypi package yet) |
|
@kalling Where would I be able to see/check if a new |
|
|
hassec
force-pushed
the
rm_omfit_classes_workaround
branch
from
f9d189f to
88a3dd8
Compare
|
@kalling yep just reran the tests and they now all pass 🎉 |
|
Stale pull request message |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@kalling As promised, removing the workaround now that
omfit_classesis updated