Skip to content

Commit

Permalink
add more explanations to the workarounds
Browse files Browse the repository at this point in the history
  • Loading branch information
hassec committed Mar 3, 2024
1 parent 87b9aa0 commit a38f1c9
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
4 changes: 4 additions & 0 deletions omas/tests/test_omas_examples.py
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,10 @@ def test_uncertain(self):

@unittest.skipIf(failed_OMFIT, str(failed_OMFIT))
def test_plot_g_s_2_ip(self):
# on 3.7 this test raises:
# ValueError: Number of rows must be a positive integer, not 7.0
# It seems like this is caused by a bug in omfit_classes where a float
# instead of int is passed to plot
if sys.version_info.minor==7:
raise unittest.SkipTest("Avoid Py 3.7 omfit_classes bug.")
from omas.examples import plot_g_s_2_ip
Expand Down
3 changes: 2 additions & 1 deletion setup.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import os
import sys
import glob
import subprocess

Expand All @@ -19,6 +18,8 @@
'setuptools>=41.2',
'tqdm',
'Cython',
# latest xarray version that works with 3.7 doesn't work
# with importlib_metadata >5 since they deprecated the `get()` method on Entrypoints
"importlib_metadata <5;python_version=='3.7'"
]

Expand Down

0 comments on commit a38f1c9

Please sign in to comment.