Cache bundle downloads #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Continued support for the buildpack depends on Dead Man's Snitch making it possible for me to spend my time working on it. If you're ever looking for a way to say thanks for this little buildpack, give Dead Man's Snitch a try and / or tell other about it. :heart:
Goal is to quickly get into a docker container so I can test out changes to the buildpack. I've added some basic documentation because I always have to figure these commands out from scratch.
GitHub's releases service recently had an issue where downloads were failing. This attempts to fix two main issues: resilience for deploys and improved error messages. Using Heroku's cache we should only need to download each version once. This will allow deploys should GitHub have issues in the future. Before this change, if there was an error downloading the bundle then the buildpack would fail with an error about bzip file formats. This now checks the http status code and prints a more useful error should it fail. Fixes #13
|
After some initial testing I'm not seeing it use the cache. Will need to do some debugging to figure out what's going on there. |
This was causing the buildpack not to use the cached version and instead it would always download the latest binary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub's releases service recently had an issue where downloads were failing. This attempts to fix two main issues: resilience for deploys and improved error messages.
Using Heroku's cache we should only need to download each version once. This will allow deploys should GitHub have issues in the future.
Before this change, if there was an error downloading the bundle then the buildpack would fail with an error about bzip file formats. This now checks the http status code and prints a more useful error should it fail.
Fixes #13