Support activity partially qualified class names

[IslamSalah]

Overview:

This plugin adds a tangible benefit for multi-module navigation. With relaxing some constrains it can be even easier to use. Especially for big-sized teams where applying constrains can add some friction. Currently the plugin fails the build with guiding error on breaking the FQCN constraint. On relaxing this constrains, things go smoother and siliently pass
CC @gaelmarhic

Type of change:

Feature

What's the purpose of this PR?

Extend the plugin capability to handle both partially & fully qualified class names for manifest files defined activities

What's the impact of this PR?

• Support partially qualified class names

<manifest xmlns:android="http://schemas.android.com/apk/res/android"
    package="com.poc.bookingfeature">

    <application>
        <activity android:name=".BookingActicity" />
...

• Retain support for fully qualified class names

<manifest xmlns:android="http://schemas.android.com/apk/res/android"
    package="com.poc.bookingfeature">

    <application>
        <activity android:name="com.poc.bookingfeature.BookingActicity" />
...

_{N.B commit by commit review can be helpful}

[gaelmarhic]

Thanks so much for your contribution @IslamSalah !
I have quite a busy week, but I will definitely have a look at it this week-end and get back to you!
Cheers :)

[gaelmarhic]

Thank you @IslamSalah once again for your contribution!
Your idea is great and its implementation is really well done!
I just added a few nitpicky comments.
Please review them and let me know what you think!
Cheers :)

[gaelmarhic]

Could we go with another name for this function? It does not "generate" a fully qualified class name all the time since some Activities are already declared that way. Could we have something like "formatClassNames" or similar?

[gaelmarhic]

Also, I know I am a bit of a maniac, but could you put your 2 new functions above the "filterClassNames" one? To make the file more readable I tried to order the functions by order of appearance :)

[IslamSalah]

It does not "generate" a fully qualified class name all the time since some Activities are already declared that way

IMO it's fine, similar to List#clear which doesn't clear the list if it's already cleared but its output is always a cleared list

[gaelmarhic]

Fair enough!

[gaelmarhic]

LGTM!

[IslamSalah]

Thank you for the review, should we expect a new release soon?

[gaelmarhic]

Just released version 1.5 including this change:
https://github.com/gaelmarhic/Quadrant/releases
https://plugins.gradle.org/plugin/com.gaelmarhic.quadrant
Let me know how it goes and thanks again ;)