Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get CI healthy on all three platforms ✅ #54

Merged
merged 24 commits into from
Apr 16, 2024
Merged

Get CI healthy on all three platforms ✅ #54

merged 24 commits into from
Apr 16, 2024

Conversation

hobu
Copy link
Contributor

@hobu hobu commented Apr 12, 2024 •
edited
Loading

This PR does the following:

  • Updates to using CMake's find_package (CONFIG) instead of self-provided FindEigen
  • Splits CI script components and parameterizes them
  • Outputs fgt.lib as a SHARED library on OSX/Linux
  • Bumps the CMake minimum version to 3.13

@hobu hobu mentioned this pull request Apr 12, 2024
Closed
@hobu hobu changed the title Some CMake and builder updates Get PR healthy on all three platforms ✅ Apr 12, 2024
@hobu hobu changed the title Get PR healthy on all three platforms ✅ Get CI healthy on all three platforms ✅ Apr 12, 2024
@hobu hobu closed this Apr 15, 2024
@hobu hobu reopened this Apr 15, 2024
@gadomski gadomski self-requested a review April 16, 2024 16:35
@gadomski gadomski merged commit a989afd into gadomski:main Apr 16, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gadomski gadomski gadomski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hobu @gadomski