-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add options
module
#97
Conversation
Awesome, @PythonCreator27, thanks for yet another contribution and your fast work on this. I'm in the middle of some international travel but will take a look as soon as I'm settled at my destination. Thanks again. |
Hey @PythonCreator27, finally had a chance to look at this. Once again, this is really great, and I really must commend you on checking all the boxes and making a perfect fit with module style, docs, tests, etc. Thanks for your continued contributions to the project! I only have two small comments:
Re CI failure, it only occurred to me now that not everyone can see the build failure messages. I'll see if we can get relevant messages directly into GitHub. The problem was the schema check... you can check if you're running the same version of Thanks again! Really great work 🙌 |
Codecov Report
@@ Coverage Diff @@
## devel #97 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 17 18 +1
Lines 311 319 +8
Branches 83 84 +1
=========================================
+ Hits 311 319 +8
Continue to review full report at Codecov.
|
* slightly smaller size without irrelevant interfaces * fixes annoying uuid change on version bump, which was for an irrelevant interface anyway
Looks great, @PythonCreator27, thank you! Ready to merge this when you are. I changed the schema generation to only include interfaces from the Oh I guess we should also update the docs to reflect the Date types, but since that's a non-code change I'm happy to do that after, up to you. Thanks again for this contribution! |
@gadicc Thanks for resolving the anonymous interface issue! Other than the merge conflict, I think that this should be good! Thanks for the amazing module! |
# [1.10.0](v1.9.1...v1.10.0) (2021-03-28) ### Features * **optionsModule:** Add `options` module ([#97](#97)) ([7ba6294](7ba6294))
🎉 This PR is included in version 1.10.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Thanks, @PythonCreator27. Looks great! Merged and released. Will reply to your comments on other issues tomorrow. Have an awesome one :D |
New module,
options
This PR adds a new module 🎉 🥳,
options
! This allows you to query calls and puts (options trading stuff?).Changes
options
Endpoint Params
formatted
- formats the response.lang
- does nothing???region
- does nothing???Example usage
Tests
I have no idea why the tests are failing on CI, they pass locally perfectly.
@gadicc Anything to change/add? Any naming conflicts (that was a slight issue when making the module) that you can spot?