Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Validation to Typebox #772

Merged
merged 13 commits into from
Aug 7, 2024

Remove JSON schema validation pathway entirely

6af931d
Select commit
Loading
Failed to load commit list.
Merged

Migrate Validation to Typebox #772

Remove JSON schema validation pathway entirely
6af931d
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Aug 4, 2024 in 0s

96.99% (+3.68%) compared to 5a6a6c8

View this Pull Request on Codecov

96.99% (+3.68%) compared to 5a6a6c8

Details

Codecov Report

Attention: Patch coverage is 98.64130% with 5 lines in your changes missing coverage. Please review.

Project coverage is 96.99%. Comparing base (5a6a6c8) to head (6af931d).
Report is 4 commits behind head on devel.

Files Patch % Lines
src/lib/datetime.ts 95.65% 2 Missing ⚠️
src/lib/yahooFinanceTypes.ts 94.59% 2 Missing ⚠️
src/modules/historical.ts 93.75% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            devel     #772      +/-   ##
==========================================
+ Coverage   93.30%   96.99%   +3.68%     
==========================================
  Files          27       30       +3     
  Lines         732      964     +232     
  Branches      247      212      -35     
==========================================
+ Hits          683      935     +252     
+ Misses         49       29      -20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.