-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(module): Add new fundamentals time series module #748
feat(module): Add new fundamentals time series module #748
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## devel #748 +/- ##
==========================================
+ Coverage 93.12% 93.41% +0.29%
==========================================
Files 26 27 +1
Lines 669 714 +45
Branches 226 240 +14
==========================================
+ Hits 623 667 +44
- Misses 46 47 +1 ☔ View full report in Codecov by Sentry. |
Wow 😮 You, Sir, are a legend! 🙇
Thanks so much! This is great! And so well timed. 🙏 🙏 |
This will be in the next release, and there'll be an automated message here when that happens. Thanks once again. How was your first contribution? Is there anything we can make clearer anywhere? |
# [2.10.0](v2.9.2...v2.10.0) (2024-03-09) ### Features * **module:** Add new fundamentals time series module ([#748](#748)) ([1681d33](1681d33))
🎉 This PR is included in version 2.10.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Hey, no problems! I've been using this library for a long time so it was nice to dig in and see how it works! I figured what I've written is probably a good start and can be iterated on, I just really wanted the data and was sad when I saw that they must have changed the API! The actual code was easy to write because I had so many good examples to reference. As for the actual contributing documentation, well considering that I've used little very little Typescript and very little yarn, it was actually very easy! I missed formatting and coverage at first and that was definitely user error, which was eventually caught by CI and I was able to easily correct. Thanks for all your hard work and kudos for such a well written library! I'll definitely keep my eyes open for more ways I can contribute! |
Closes #745
Changes
Type
Comments/notes