Add sectorKey and industryKey to assetProfile
#689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## devel #689 +/- ##
=======================================
Coverage 93.12% 93.12%
=======================================
Files 26 26
Lines 669 669
Branches 226 226
=======================================
Hits 623 623
Misses 46 46 ☔ View full report in Codecov by Sentry. |
|
Hey @martinnormark, thanks for another very welcome PR. Apologies for the delay as I've been travelling. Merging now and this will be in the next release. Thanks again for your time, efforts and patience. |
|
🎉 This PR is included in version 2.8.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
Hey @gadicc - no worries, always great to contribute to open source. Hopefully I did the changes in the right way for schema validation. |
|
All looked perfect to me! 💯 Thanks for your attention to detail 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed validation error in quote summary, caused by new fields in the
assetProfilemodule.Changes
quoteSummary-iface.tsand built schema.Type