feat(module): add dailyGainers #666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## devel #666 +/- ##
==========================================
+ Coverage 95.68% 95.73% +0.05%
==========================================
Files 24 25 +1
Lines 625 633 +8
Branches 211 212 +1
==========================================
+ Hits 598 606 +8
Misses 27 27
☔ View full report in Codecov by Sentry. |
|
I am honestly not sure why its failing the coverage test, but it could be due to me not being familiar with the jest framework lol module works tho :) |
|
@z3nful, you legend!
Very happy to have you here and thanks for your contributions to the project! And I see you figured out the testing, coverage, everything 🙌 Going to merge now and it will be in the next release, and there'll be an automated message here when its published. |
gadicc
pushed a commit
that referenced
this pull request
Sep 7, 2023
# [2.5.0](v2.4.7...v2.5.0) (2023-09-07) ### Features * **dailyGainers:** add new dailyGainers module ([#666](#666)) ([5085014](5085014))
|
🎉 This PR is included in version 2.5.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
gadicc
pushed a commit
that referenced
this pull request
Sep 15, 2023
# [2.5.0](v2.4.7...v2.5.0) (2023-09-07) ### Features * **dailyGainers:** add new dailyGainers module ([#666](#666)) ([5085014](5085014))
gadicc
pushed a commit
that referenced
this pull request
Sep 18, 2023
# [2.5.0](v2.4.7...v2.5.0) (2023-09-07) ### Features * **dailyGainers:** add new dailyGainers module ([#666](#666)) ([5085014](5085014))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #8 .
Changes
Type
Comments/notes
There may still be some fields that are returned later that this doesn't account for, but it covers all data returned from my tests yesterday and today. Also, changing region doesn't seem to do anything, always returns US