feat(modules): add trendingSymbols module #66
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New module
trendingSymbols
This PR adds a new module 🎉,
trendingSymbols
! It provides the symbols that are trending in your region (country in this case, as far as I can tell).Changes
trendingSymbols
Endpoint Params
count
- max number of symbols that can be returned.lang
- does nothing???region
- overrides the search country, alternative to passing the query.corsDomain
(not added) - This was provided in #8, but does not actually set the cors domain, so it is not added in the PR (better not to add it than to release a new major version for removing it).Tests
Tests will not pass until #64 is merged, but tests for the module pass.
Example usage
@gadicc What are your thoughts on this? Anything to change?