Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fundamental timeseries is missing data points #752

Closed
nocodehummel opened this issue Mar 17, 2024 · 1 comment · Fixed by #753
Closed

Fundamental timeseries is missing data points #752

nocodehummel opened this issue Mar 17, 2024 · 1 comment · Fixed by #753
Labels
bug Something isn't working released

Comments

@nocodehummel
Copy link
Contributor

nocodehummel commented Mar 17, 2024

Bug Report

Describe the bug

The recently added fundamentals time-series to retrieve financial statements is missing (many) data points (e.g. gross profit). The data point types are extracted from an example URL (see #733), but should actually represent the financial data is shown on the Yahoo Finance UI.

Minimal Reproduction

await yahooFinance.fundamentalsTimeSeries('AAPL', { type: 'annual' })

Environment

Browser or Node: Node
Node version (if applicable):
npm version: 10.2.4
Browser version (if applicable):
Library version (e.g. 1.10.1):

Additional Context

In addition fundamentalsTimeSeries supports annual and quarterly but is missing trailing.

@Shadaeiou did an excellent job on the first version. An update is needed on the data point types used.

@nocodehummel nocodehummel added the bug Something isn't working label Mar 17, 2024
@nocodehummel nocodehummel changed the title Fundamental timeseries is missing data point Fundamental timeseries is missing data points Mar 17, 2024
nocodehummel added a commit to alphaboard-io/yahoo-finance that referenced this issue Mar 17, 2024
BREAKING CHANGEs:
- requires option module.
- type is removed from data key.
gadicc pushed a commit that referenced this issue Mar 20, 2024
* #752!: resolved missing data points.

BREAKING CHANGEs:
- requires option module.
- type is removed from data key.

* Generated schema.

* Fixed prettier warnings.

* Format const with camel case.

* Fixed tests with options module required by schema.

* Saved with LF.

* Support for option module all.

* Aligned modules with Yahoo names and moved keys to json file.

* HAR file script to extract keys from requests.

* Fixed test coverage warnings.

* More time-series keys and minor script improvement.

* Changed keys means changed results :-).

* Test cases per module and period type to verify the results.
@gadicc
Copy link
Owner

gadicc commented Mar 20, 2024

🎉 This issue has been resolved in version 2.11.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants