Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed validation: #/definitions/QuoteSummaryResult #744

Closed
cstange opened this issue Mar 7, 2024 · 2 comments
Closed

Failed validation: #/definitions/QuoteSummaryResult #744

cstange opened this issue Mar 7, 2024 · 2 comments
Labels
bug Something isn't working released validation Issues related to validation

Comments

@cstange
Copy link

cstange commented Mar 7, 2024

Validation Error

Minimal Reproduction

await yF.quoteSummary('SPY', { modules: ['fundPerformance'] });

Symbol(s) that it happened for

  • SPY

Error Message

The following result did not validate with schema: #/definitions/QuoteSummaryResult
[
  {
    instancePath: '/fundPerformance/riskOverviewStatisticsCat/riskStatisticsCat/0',
    schemaPath: '#/definitions/FundPerformanceRiskOverviewStatsRow/required',
    keyword: 'required',
    params: { missingProperty: 'stdDev' },
    message: "must have required property 'stdDev'",
    data: {
      year: '5y',
      alpha: -1.12,
      beta: 0.98,
      meanAnnualReturn: 1.18,
      rSquared: 94.98,
      sharpeRatio: 0.65,
      treynorRatio: 11.32
    }
  },
  {
    instancePath: '/fundPerformance/riskOverviewStatisticsCat/riskStatisticsCat/1',
    schemaPath: '#/definitions/FundPerformanceRiskOverviewStatsRow/required',
    keyword: 'required',
    params: { missingProperty: 'stdDev' },
    message: "must have required property 'stdDev'",
    data: {
      year: '3y',
      alpha: -1.08,
      beta: 0.96,
      meanAnnualReturn: 0.94,
      rSquared: 94.11,
      sharpeRatio: 0.49,
      treynorRatio: 7.87
    }
  },
  {
    instancePath: '/fundPerformance/riskOverviewStatisticsCat/riskStatisticsCat/2',
    schemaPath: '#/definitions/FundPerformanceRiskOverviewStatsRow/required',
    keyword: 'required',
    params: { missingProperty: 'stdDev' },
    message: "must have required property 'stdDev'",
    data: {
      year: '10y',
      alpha: -1.25,
      beta: 0.99,
      meanAnnualReturn: 0.98,
      rSquared: 94.95,
      sharpeRatio: 0.68,
      treynorRatio: 9.85
    }
  }
]

Environment

Browser or Node: node
Node version (if applicable): v16.15.0
Npm version:
Browser version (if applicable):
Library version (e.g. 1.10.1): v2.9.1

Additional Context

@cstange cstange added bug Something isn't working validation Issues related to validation labels Mar 7, 2024
@gadicc gadicc closed this as completed in fc1430e Mar 7, 2024
@gadicc
Copy link
Owner

gadicc commented Mar 7, 2024

Thanks, @cstange, for the report. This has been fixed and will be in the next release. There'll be an automatic message here when that happens.

gadicc pushed a commit that referenced this issue Mar 7, 2024
## [2.9.2](v2.9.1...v2.9.2) (2024-03-07)

### Bug Fixes

* **quoteSummary:** stdDev ? in FPerfRiskOverviewStatsRow (fix [#744](#744)) ([fc1430e](fc1430e))
@gadicc
Copy link
Owner

gadicc commented Mar 7, 2024

🎉 This issue has been resolved in version 2.9.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@gadicc gadicc added the released label Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released validation Issues related to validation
Projects
None yet
Development

No branches or pull requests

2 participants