Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed validation: #/definitions/QuoteSummaryResult: #734

Closed
martincsl opened this issue Jan 31, 2024 · 3 comments
Closed

Failed validation: #/definitions/QuoteSummaryResult: #734

martincsl opened this issue Jan 31, 2024 · 3 comments
Labels
bug Something isn't working released validation Issues related to validation

Comments

@martincsl
Copy link

Validation Error

Minimal Reproduction

await yahooFinance.quoteSummary('PLTR', { modules: [ "incomeStatementHistory" ] });

Symbol(s) that it happened for

  • JPM
  • CVX
  • AAPL

Error Message

"error": "Failed Yahoo Schema validation"

Environment

Browser or Node: Node
Node version (if applicable): v16.13.0
Npm version:
Browser version (if applicable):
Library version (e.g. 1.10.1):

Additional Context

@martincsl martincsl added bug Something isn't working validation Issues related to validation labels Jan 31, 2024
@martincsl
Copy link
Author

hello friends, do you know if yahoo finance change the structure? This error is happening under the QuoteSummay. Quote seems to working poperly.
I've been using wait yahooFinance.quoteSummary('PLTR', { modules: [ "incomeStatementHistory" ] }) for some time with any problem. But now i'm receiving this error message: "error": "Failed Yahoo Schema validation".

Thanks in advance!

@gadicc gadicc closed this as completed in 1d0d48e Feb 5, 2024
@gadicc
Copy link
Owner

gadicc commented Feb 5, 2024

Thanks @martincsl, for reporting.

Yes, Yahoo do occasionally change their output, which is why we need to watch it so carefully, to ensure the library gives a catchable error before returning you a new kind of data structure which can completely break your app / code / db :D

So, thanks for reporting. This has been fixed and will be in the next release. There'll be an automatic message here when that happens.

gadicc pushed a commit that referenced this issue Feb 5, 2024
## [2.9.1](v2.9.0...v2.9.1) (2024-02-05)

### Bug Fixes

* **options:** add { needsCrumb: true } (fixes [#736](#736)) ([79e33d9](79e33d9))
* **quoteSummary:** allow totalOtherIncomeExpenseNet null (fixes [#734](#734)) ([1d0d48e](1d0d48e))
* **quoteSummary:** moduleName s/search/quoteSummary/ fix ([bf58aa8](bf58aa8))
@gadicc
Copy link
Owner

gadicc commented Feb 5, 2024

🎉 This issue has been resolved in version 2.9.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released validation Issues related to validation
Projects
None yet
Development

No branches or pull requests

2 participants