Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed validation: #/definitions/QuoteSummaryResult #664

Closed
z3nful opened this issue Sep 5, 2023 · 2 comments · Fixed by #665
Closed

Failed validation: #/definitions/QuoteSummaryResult #664

z3nful opened this issue Sep 5, 2023 · 2 comments · Fixed by #665
Labels
bug Something isn't working released validation Issues related to validation

Comments

@z3nful
Copy link
Contributor

z3nful commented Sep 5, 2023

Validation Error

Minimal Reproduction

const results = await yahooFinance.quoteSummary("EURN", {
modules: ["secFilings"]
});

Symbol(s) that it happened for

  • EURN
  • ARMK
  • Other Foreign Companies

Error Message

Same property for all of them
{
    instancePath: '/secFilings/filings/0/type',
    schemaPath: '#/definitions/Filing/properties/type/enum',
    keyword: 'enum',
    params: {
      allowedValues: [
        '10-K',     '10-Q',
        '8-K',      '8-K/A',
        '10-K/A',   '10-Q/A',
        'SD',       'PX14A6G',
        'SC 13G/A', 'DEFA14A',
        '25-NSE',   'S-8 POS'
      ]
    },
    message: 'must be equal to one of the allowed values',
    data: '6-K'
  }

Environment

Browser or Node:
Node version (if applicable):
Npm version:
Browser verion (if applicable):
Library version (e.g. 1.10.1):
2.4.6

Additional Context

The following forms are all failing Validation:
6-K
F-3ASR
SC 13D/A
20-F
425
SC14D9C
SC 13G
S-8
DEF 14A
F-10

@z3nful z3nful added bug Something isn't working validation Issues related to validation labels Sep 5, 2023
gadicc pushed a commit that referenced this issue Sep 6, 2023
Partially closes #663 , and closes #664.

* Fixes Insights Validation Errors
* Add missing forms for non-US companies
* schema update
* prettier
gadicc pushed a commit that referenced this issue Sep 6, 2023
## [2.4.7](v2.4.6...v2.4.7) (2023-09-06)

### Bug Fixes

* **insights:** Insights and SEC Filings validation errors ([#665](#665)) ([23f2789](23f2789)), closes [#663](#663) [#664](#664)
* **insights:** missing/optional fields/enums, tests (fixes [#663](#663)) ([3c02753](3c02753))
* **quoteSummary:** add Grade "ConvictionBuy"; tests foR ARMK ([#664](#664)) ([c0efc07](c0efc07))
@gadicc
Copy link
Owner

gadicc commented Sep 6, 2023

🎉 This issue has been resolved in version 2.4.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

@gadicc gadicc added the released label Sep 6, 2023
@gadicc
Copy link
Owner

gadicc commented Sep 6, 2023

Reported and fixed by @z3nful; thanks! 🙏

gadicc pushed a commit that referenced this issue Sep 15, 2023
## [2.4.7](v2.4.6...v2.4.7) (2023-09-06)

### Bug Fixes

* **insights:** Insights and SEC Filings validation errors ([#665](#665)) ([23f2789](23f2789)), closes [#663](#663) [#664](#664)
* **insights:** missing/optional fields/enums, tests (fixes [#663](#663)) ([3c02753](3c02753))
* **quoteSummary:** add Grade "ConvictionBuy"; tests foR ARMK ([#664](#664)) ([c0efc07](c0efc07))
gadicc pushed a commit that referenced this issue Sep 18, 2023
## [2.4.7](v2.4.6...v2.4.7) (2023-09-06)

### Bug Fixes

* **insights:** Insights and SEC Filings validation errors ([#665](#665)) ([23f2789](23f2789)), closes [#663](#663) [#664](#664)
* **insights:** missing/optional fields/enums, tests (fixes [#663](#663)) ([3c02753](3c02753))
* **quoteSummary:** add Grade "ConvictionBuy"; tests foR ARMK ([#664](#664)) ([c0efc07](c0efc07))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released validation Issues related to validation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants