Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fetch] URL validation with { devel: filename } #34

Closed
2 tasks done
gadicc opened this issue Feb 10, 2021 · 0 comments
Closed
2 tasks done

[fetch] URL validation with { devel: filename } #34

gadicc opened this issue Feb 10, 2021 · 0 comments

Comments

@gadicc
Copy link
Owner

gadicc commented Feb 10, 2021

Following on from #27 (comment), if we use { devel: true }, we get a filename that's unique to everyone URL. But if we specify { devel: filename }, we can override that with an easy to understand name. The downside is that it's no longer unique per URL, which means that, we could change URL options (e.g. default options) and we'd still test against the original query.

  • Validate that URL is the same before turning cache entry, warn or throw otherwise
  • Fix tests that purposefully use result from another module
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant