quoteSummary dates in additional modules #263
Labels
Comments
|
@gadicc If you are not already working on this issue i would be happy to check for other incorrect formats and try to fix this then. |
|
Oh wow, sure, if you're happy to take this on that would be amazing! Should be as simple as simple as:
but I could be missing something else. Thanks! |
gadicc
pushed a commit
that referenced
this issue
Oct 24, 2021
BREAKING CHANGE: use `date` instead of `number` for various fields. The original use of `number` was unintentional. This commit fixes that. Unfortunately the type change is a breaking change. * docs: add insiderTransaction example * docs: add insiderHolders example * docs: add netSharePurchaseActivity example * docs: add institutionOwnership example * docs: add cashflowStatementHistoryQuarterly example * docs: add fundOwnership example * docs: add incomeStatementHistory example * docs: add incomeStatementHistoryQuarterly example * docs: add indexTrend example * docs: add industryTrend example * docs: add majorDirectHolders example * docs: add majorHoldersBreakdown example * docs: add quoteType example * docs: add recommendationTrend example * docs: add sectorTrend example * docs: add fundPerformance example * docs: add fundProfile example * docs: add missing symbols in example request * docs: correct example response * docs: correct defaultKeyStatistics example * docs: align date format * feat(#263): replace timestamps with date objects * docs(#263): update docs according to new date format
gadicc
pushed a commit
that referenced
this issue
Oct 27, 2021
# [2.0.0](v1.14.6...v2.0.0) (2021-10-27) ### Bug Fixes * **search:** allow exchDisp? type ([80236e5](80236e5)) * **validation:** correctly handle null dates + coverage ([#264](#264)) ([68378d5](68378d5)) ### Features * **validation:** add support for "date|null" type ([#264](#264)) ([52ea8e4](52ea8e4)) * feat(quoteSummary)!: unify date format (#264) ([4cf1f62](4cf1f62)), closes [#264](#264) [#263](#263) [#263](#263) ### BREAKING CHANGES * use `date` instead of `number` for various fields. The original use of `number` was unintentional. This commit fixes that. Unfortunately the type change is a breaking change. * docs: add insiderTransaction example * docs: add insiderHolders example * docs: add netSharePurchaseActivity example * docs: add institutionOwnership example * docs: add cashflowStatementHistoryQuarterly example * docs: add fundOwnership example * docs: add incomeStatementHistory example * docs: add incomeStatementHistoryQuarterly example * docs: add indexTrend example * docs: add industryTrend example * docs: add majorDirectHolders example * docs: add majorHoldersBreakdown example * docs: add quoteType example * docs: add recommendationTrend example * docs: add sectorTrend example * docs: add fundPerformance example * docs: add fundProfile example * docs: add missing symbols in example request * docs: correct example response * docs: correct defaultKeyStatistics example * docs: align date format
|
🎉 This issue has been resolved in version 2.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Bug Report
Describe the bug
Some of the additional modules incorrectly return dates as numbers.
DefaultKeyStatistics
insiderHolders
Possibly others, need to check.
The text was updated successfully, but these errors were encountered: