We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When calling the search module without passing queryOptionsOverrides it'll throw an error.
search
queryOptionsOverrides
UnhandledPromiseRejectionWarning: InvalidOptionsError: yahooFinance.search called with invalid options.
await yahooFinance2.search('Apple');
I think it's related to this commit.
The data flow is this:
search('Apple')
moduleExec
query.overrides
validateAndCoerceTypes()
validateAndCoerceTypes
And the issue is in 3), that we are trying to validate the overrides solely. We should validate the DEFAULTS + OVERRIDES.
3)
The text was updated successfully, but these errors were encountered:
@gadicc I'll prepare a PR for this. Should be a one line change.
Sorry, something went wrong.
chore(moduleExec): test for undefined queryOpts (#24, #27)
8017659
🎉 This issue has been resolved in version 1.7.0 🎉
The release is available on:
Your semantic-release bot 📦🚀
Successfully merging a pull request may close this issue.
Issue
When calling the
search
module without passingqueryOptionsOverrides
it'll throw an error.How to replicate
Possible solution
I think it's related to this commit.
The data flow is this:
search('Apple')
withoutqueryOptionsOverrides
search
module callsmoduleExec
, wherequery.overrides
is undefinedmoduleExec
callsvalidateAndCoerceTypes()
where it passes an undefined objectvalidateAndCoerceTypes
tries to validate an undefined objectAnd the issue is in
3)
, that we are trying to validate the overrides solely. We should validate the DEFAULTS + OVERRIDES.The text was updated successfully, but these errors were encountered: