Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed validation: #/definitions/QuoteSummaryResult #197

Open
blaur opened this issue Jun 2, 2021 · 4 comments
Open

Failed validation: #/definitions/QuoteSummaryResult #197

blaur opened this issue Jun 2, 2021 · 4 comments
Labels
bug Something isn't working released validation Issues related to validation

Comments

@blaur
Copy link

blaur commented Jun 2, 2021

Seeing this for ORSTED.CO

"error":{"name":"FailedYahooValidationError","errors":[{"instancePath":"/price/shortName","message":"must be string","schemaPath":"#/definitions/Price/properties/shortName/type","params":{"type":"string"},"keyword":"type","data":null}],"result":{"price":{"quoteType":"EQUITY","shortName":null,"regularMarketPrice":925.8,"marketCap":388898947072,"currency":"DKK","marketState":"PREPRE","regularMarketOpen":926.2,"regularMarketVolume":423244,"regularMarketDayHigh":945,"priceHint":2,"regularMarketChangePercent":0.0032509754,"longName":"Ørsted A/S","regularMarketSource":"FREE_REALTIME","toCurrency":null,"regularMarketDayLow":916.6,"exchangeDataDelayedBy":0,"lastMarket":null,"symbol":"ORSTED.CO","fromCurrency":null,"maxAge":1,"quoteSourceName":"Delayed Quote","exchangeName":"Copenhagen","underlyingSymbol":null,"regularMarketChange":3,"exchange":"CPH","currencySymbol":"kr.","regularMarketTime":{},"regularMarketPreviousClose":922.8}}

@gadicc gadicc closed this as completed in 990dd4a Jun 2, 2021
gadicc pushed a commit that referenced this issue Jun 2, 2021
# [1.12.0](v1.11.0...v1.12.0) (2021-06-02)

### Bug Fixes

* **quoteSummary:** allow price=null in price,quoteType (fixes [#197](#197)) ([990dd4a](990dd4a))

### Features

* **quote:** support { "return": "array"* | "map" | "object" } param ([#151](#151)) ([a2d8796](a2d8796))
@gadicc
Copy link
Owner

gadicc commented Jun 2, 2021

🎉 This issue has been resolved in version 1.12.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@gadicc gadicc added the released label Jun 2, 2021
@gadicc gadicc reopened this Jun 2, 2021
@gadicc
Copy link
Owner

gadicc commented Jun 2, 2021

Oops, didn't mean to close this, but it's fixed now in the latest release. If you can confirm, you can close. Thanks :) And thanks for reporting!

@gadicc gadicc added bug Something isn't working validation Issues related to validation labels Jun 2, 2021
@blaur
Copy link
Author

blaur commented Jun 2, 2021

Seeing this now:

node_modules/yahoo-finance2/node_modules/ajv/dist/types/json-schema.d.ts:1:92 - error TS1005: '?' expected.

1 declare type StrictNullChecksWrapper<Name extends string, Type> = undefined extends null ? `strictNullChecks must be true in tsconfig to use ${Name}` : Type;
                                                                                             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

node_modules/yahoo-finance2/node_modules/ajv/dist/types/json-schema.d.ts:1:151 - error TS1005: ';' expected.

1 declare type StrictNullChecksWrapper<Name extends string, Type> = undefined extends null ? `strictNullChecks must be true in tsconfig to use ${Name}` : Type;
                 

Seems like something is missing in the schemda.d.ts? because i have strictNullChecks: true in my tsconfig

@gadicc
Copy link
Owner

gadicc commented Jun 2, 2021

Hey @blaur, I'm moving my reply to #198 for clarity. Let's continue this part of the discussion there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released validation Issues related to validation
Projects
None yet
Development

No branches or pull requests

2 participants