fix(quoteCombine): resolve undefined for missing symbols (#150)

gadicc · Apr 28, 2021 · f8c25e3 · f8c25e3
1 parent bebb7d6
commit f8c25e3
Showing 1 changed file with 15 additions and 2 deletions.
diff --git a/src/other/quoteCombine.ts b/src/other/quoteCombine.ts
@@ -84,9 +84,22 @@ export default function quoteCombine(
       // @ts-ignore
       thisQuote(symbols, queryOptionsOverrides, moduleOptions)
         .then((results) => {
-          for (let result of results)
-            for (let promise of entry.symbols.get(result.symbol))
+          for (let result of results) {
+            for (let promise of entry.symbols.get(result.symbol)) {
               promise.resolve(result);
+              promise.resolved = true;
+            }
+          }
+
+          // Check for symbols we asked for and didn't get back,
+          // e.g. non-existant symbols (#150)
+          for (let [symbol, promises] of entry.symbols) {
+            for (let promise of promises) {
+              if (!promise.resolved) {
+                promise.resolve(undefined);
+              }
+            }
+          }
         })
         .catch((error) => {
           for (let symbolPromiseCallbacks of entry.symbols.values())