fix(options,quote): EBAY "ask", "cryptoTradeable" fields (fixes #560)

gadicc · Nov 16, 2022 · b2c4b5a · b2c4b5a
1 parent 5f0e1b3
commit b2c4b5a
Show file tree

Hide file tree

Showing 5 changed files with 1,912 additions and 2 deletions.
diff --git a/schema.json b/schema.json
@@ -1584,6 +1584,9 @@
         "tradeable": {
           "type": "boolean"
         },
+        "cryptoTradeable": {
+          "type": "boolean"
+        },
         "exchange": {
           "type": "string"
         },
@@ -1906,6 +1909,9 @@
         "tradeable": {
           "type": "boolean"
         },
+        "cryptoTradeable": {
+          "type": "boolean"
+        },
         "exchange": {
           "type": "string"
         },
@@ -2240,6 +2246,9 @@
         "tradeable": {
           "type": "boolean"
         },
+        "cryptoTradeable": {
+          "type": "boolean"
+        },
         "exchange": {
           "type": "string"
         },
@@ -2546,6 +2555,9 @@
         "tradeable": {
           "type": "boolean"
         },
+        "cryptoTradeable": {
+          "type": "boolean"
+        },
         "exchange": {
           "type": "string"
         },
@@ -2852,6 +2864,9 @@
         "tradeable": {
           "type": "boolean"
         },
+        "cryptoTradeable": {
+          "type": "boolean"
+        },
         "exchange": {
           "type": "string"
         },
@@ -3158,6 +3173,9 @@
         "tradeable": {
           "type": "boolean"
         },
+        "cryptoTradeable": {
+          "type": "boolean"
+        },
         "exchange": {
           "type": "string"
         },
@@ -3484,6 +3502,9 @@
         "tradeable": {
           "type": "boolean"
         },
+        "cryptoTradeable": {
+          "type": "boolean"
+        },
         "exchange": {
           "type": "string"
         },
@@ -3790,6 +3811,9 @@
         "tradeable": {
           "type": "boolean"
         },
+        "cryptoTradeable": {
+          "type": "boolean"
+        },
         "exchange": {
           "type": "string"
         },
@@ -4110,6 +4134,9 @@
         "tradeable": {
           "type": "boolean"
         },
+        "cryptoTradeable": {
+          "type": "boolean"
+        },
         "exchange": {
           "type": "string"
         },
@@ -4423,6 +4450,7 @@
         "customPriceAlertConfidence",
         "marketState",
         "tradeable",
+        "cryptoTradeable",
         "exchange",
         "shortName",
         "longName",
@@ -4771,7 +4799,6 @@
         "lastPrice",
         "change",
         "percentChange",
-        "ask",
         "contractSize",
         "expiration",
         "lastTradeDate",

diff --git a/src/modules/options.spec.ts b/src/modules/options.spec.ts
@@ -11,6 +11,9 @@ describe("options", () => {
       //   {strike: 97.5 }, {expirationDate: 1649894400 }
       "BRKS",
     ],
+    add: [
+      "EBAY", // Missing "ask" (#560)
+    ],
   });
 
   it.each(symbols)("passes validation for symbol '%s'", async (symbol) => {

diff --git a/src/modules/options.ts b/src/modules/options.ts
@@ -36,7 +36,7 @@ export interface CallOrPut {
   volume?: number;
   openInterest?: number;
   bid?: number;
-  ask: number;
+  ask?: number;
   contractSize: "REGULAR";
   expiration: Date;
   lastTradeDate: Date;

diff --git a/src/modules/quote.ts b/src/modules/quote.ts
@@ -20,6 +20,7 @@ export interface QuoteBase {
   customPriceAlertConfidence?: string; // "HIGH" | "LOW"; TODO: anything else?
   marketState: "REGULAR" | "CLOSED" | "PRE" | "PREPRE" | "POST" | "POSTPOST";
   tradeable: boolean; // false,
+  cryptoTradeable?: boolean; // false
   exchange: string; // "NMS",
   shortName?: string; // "NVIDIA Corporation",
   longName?: string; // "NVIDIA Corporation",
-Original file line number
+Diff line change
@@ Expand Up / @@ -11,6 +11,9 @@ describe("options", () => { @@
           //   {strike: 97.5 }, {expirationDate: 1649894400 }
           "BRKS",
         ],
+        add: [
+          "EBAY", // Missing "ask" (#560)
+        ],
       });
       it.each(symbols)("passes validation for symbol '%s'", async (symbol) => {
@@ Expand Down @@