Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

withCalls mapPipe not working correctly #148

Closed
gabrielguerrero opened this issue Dec 8, 2024 · 1 comment · Fixed by #149
Closed

withCalls mapPipe not working correctly #148

gabrielguerrero opened this issue Dec 8, 2024 · 1 comment · Fixed by #149
Labels

Comments

@gabrielguerrero
Copy link
Owner

The willCalls mapPipe by default is meant to be using exhaustMap but due to a bug is behaving like concatMap , the following cases where not working correctly

typescrypt

const Store = signalStore(
        { providedIn: 'root' },
        withCalls(() => ({
          testCall: typedCallConfig({
            call: call,
            mapPipe: 'exhaustMap',
          }),
        })),
      );   
typescrypt

const Store = signalStore(
        { providedIn: 'root' },
        withCalls(() => ({
          testCall: typedCallConfig({
            call: call,
            mapPipe: 'switchMap',
          }),
        })),
      );   

This should fix the problem and add extra test to ensure they work correctly

gabrielguerrero pushed a commit that referenced this issue Dec 8, 2024
Due to a bug when using mapPipe: exhaustMap or switchMap was always behaving like a concatMap, this
pr fixes the issue and adds tests

fix #148
gabrielguerrero pushed a commit that referenced this issue Dec 9, 2024
Due to a bug when using mapPipe: exhaustMap or switchMap was always behaving like a concatMap, this
pr fixes the issue and adds tests

fix #148
Copy link

github-actions bot commented Dec 9, 2024

🎉 This issue has been resolved in version 18.4.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant