Skip to content

Commit

Permalink
remove exe from testdata (#561)
Browse files Browse the repository at this point in the history
After considering #550 and #551, there seems it's hard to create a
windows executable that satisfies these 2 conditions:
- is small in size
- does not trigger antivirus alerts; seems like many antiviruses just
  don't care what's inside an exe. If it's .exe then it's a virus.

Looking back on it, adding fixture files is not perfect: seems nice to
have the library tests work with real files, but:
- it does not count towards test-coverage
- real files increase repo size

Going forward I think I will remove more and more of the files in
testdata folder, and add more unit tests.
  • Loading branch information
gabriel-vasile authored Jul 26, 2024
1 parent e802551 commit b36b70f
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion mimetype_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,6 @@ var files = map[string]string{
"dwg.dwg": "image/vnd.dwg",
"eot.eot": "application/vnd.ms-fontobject",
"epub.epub": "application/epub+zip",
"exe.exe": "application/vnd.microsoft.portable-executable",
"fdf.fdf": "application/vnd.fdf",
"fits.fits": "application/fits",
"flac.flac": "audio/flac",
Expand Down
Binary file removed testdata/exe.exe
Binary file not shown.

0 comments on commit b36b70f

Please sign in to comment.