Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sustitute {callr} dependency #20

Merged
merged 5 commits into from
Aug 30, 2023

Conversation

gaborcsardi
Copy link
Owner

@gaborcsardi gaborcsardi commented Aug 30, 2023

@gaborcsardi gaborcsardi changed the title add standard workflow Sustitute {callr} dependency Aug 30, 2023
@gaborcsardi gaborcsardi merged commit b9b0c5a into gaborcsardi:main Aug 30, 2023
@gaborcsardi
Copy link
Owner Author

@lorenzwalthert I merged this, but it seems to break cyclocomp_package_dir(). Can you please take a look?

@lorenzwalthert
Copy link

ufff... Long time... Hopefully before the weekend.

@gaborcsardi
Copy link
Owner Author

Actually, never mind, I'll have to undo this, because if you load the package into the current R session once, then you won't be able to update and reload it without restarting R.

@lorenzwalthert
Copy link

Ok, so we can't get rid of the {callr} dependency?

@gaborcsardi
Copy link
Owner Author

Ok, so we can't get rid of the {callr} dependency?

Not without seriously crippling cyclocomp_package_dir().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants