Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for toggling visibility of toolbars #45

Merged
merged 6 commits into from
Feb 23, 2024
Merged

feat: add support for toggling visibility of toolbars #45

merged 6 commits into from
Feb 23, 2024

Conversation

mistgc
Copy link
Contributor

@mistgc mistgc commented Feb 14, 2024

Commit PR according to #42

@gabm
Copy link
Owner

gabm commented Feb 19, 2024

nice.. could you resolve conflicts?

@mistgc
Copy link
Contributor Author

mistgc commented Feb 19, 2024

My bad. I am going to fix it now.

@gabm
Copy link
Owner

gabm commented Feb 21, 2024

there are still some errors in the readme

@mistgc
Copy link
Contributor Author

mistgc commented Feb 21, 2024

Sorry, I was too careless.

@gabm
Copy link
Owner

gabm commented Feb 23, 2024

I refactored your PR

  • I removed explicit state handling in main.rs
  • I removed the backchannel into sketchboard for now - since we dont take action

If you are okay and you confirm it still works, I'll merge it

Copy link
Contributor Author

@mistgc mistgc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your refactoring. It can still work stably.

@gabm gabm merged commit 2283b12 into gabm:main Feb 23, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants