Execute copy-command via system shell
#119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
oh thats great @LRitzdorf, thank you for hunting this down. |
|
.. unfortunately it doesn't compile .. could you check? |
|
...oh, duh, Edit: And I even tested it locally this time! |
...specifically, `sh`. This allows for commands with arguments, such as `wl-copy -t image/png`, or even more advanced shell features. This technically also allows for arbitrary command execution, but the user already has execution privileges anyway if they're providing a copy command.
|
FYI, this does indeed compile now, and I've gotten around to testing the full executable on my system, where it works as expected! |
|
great thanks! |
|
Any clue when this will be released ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...specifically,
sh. This allows for commands with arguments, such aswl-copy -t image/png, or even more advanced shell features.This technically also allows for arbitrary command execution, but the user already has execution privileges anyway if they're providing a copy command.
Fixes #105