fix: remove unused to_string_view overload in fmt >= 11.1 #3314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @jdrouhard |
|
Thank you so much for this fix as it means that the latest fmt release v11.1.1 (2024-12-27) can be successfully used with latest (at time of compilation) spdlog r.96a7d2a1 |
davidebeatrici
added a commit
to OpenMandrivaAssociation/spdlog
that referenced
this pull request
Jan 16, 2025
This supersedes the patch added in the previous commit. That one is retained so that we can apply the new one without modifications. gabime/spdlog#3314
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This overload was added in #3301 based on a compiler error quickfix suggestion.
fmt's
fmt::format_stringtype has had an implicit conversion operator tofmt::string_viewsince fmt 8.0 (introduced here).Since there is already an overload for
to_string_view()that no-opsspdlog::string_view_t(which is typedef'd tofmt::string_viewwhen using fmt), we don't need any other overloads forformat_string.